-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Calico to v3.22.1 #2147
Update Calico to v3.22.1 #2147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Makes sense for a quick fix, but I agree this is a maintenance problem.
5bdfe0e
to
ead3506
Compare
updated the Windows images as well /assign @jsturtevant |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/test pull-cluster-api-provider-azure-e2e |
What type of PR is this?
/kind cleanup
What this PR does / why we need it: This is a quick fix to unblock the verify test.
next step: find a way to not break the make verify test whenever a new version of calico is released. Because the source manifest used in our calico kustomization file as source manifest (https://docs.projectcalico.org/v3.22/manifests/calico-vxlan.yaml) is for a minor release of calico and not a specific release, it gets updated each time a patch is released and this cannot be used as a reliable source because it is mutable. We need to find a way to pin to a specific release while keeping the ability to update the manifest easily by just changing the version when needed.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: